netdev - Re: [PATCH 09/15] tg3: Allow WOL for phylib controlled Broadcom phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2acbd3e40811031509q3d3005e5g9fedd842a1d08a52@mail.gmail.com>
Date:	Mon, 3 Nov 2008 17:09:34 -0600
From:	"Andy Fleming" <afleming@...il.com>
To:	"Matt Carlson" <mcarlson@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	"Michael Chan" <mchan@...adcom.com>, andy@...yhouse.net
Subject: Re: [PATCH 09/15] tg3: Allow WOL for phylib controlled Broadcom phys

On Mon, Nov 3, 2008 at 4:13 AM, Matt Carlson <mcarlson@...adcom.com> wrote:
> This patch allows WOL to be enabled for Broadcom phys under phylib
> control.  The only exception is the AC131, which has a completely
> different register set.
>
> Signed-off-by: Matt Carlson <mcarlson@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Code to enable WOL sounds like the sort of thing we'd want in the PHY
driver itself, rather than a manual setup done from the NIC driver.
Clearly, we need support for WOL on both in order for it to work,
though, so I can see two solutions off the top of my head:

1) phy_connect() allows for passing in flags.  Maybe we should create
one for WOL, and have the config_init() functions for the Broadcom
PHYs check that, and set it up.

2) The appropriate code can register a phy_fixup, which will be
invoked whenever the PHY is initialized.  The fixup can be restricted
based on PHY ID and address.

It seems to me that WOL support is probably a common desire, so we
should either always enable it, or provide generic infrastructure for
enabling it, so that your driver doesn't need to know what PHY it is
connecting to.

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html