netdev - Re: [PATCH 09/15] tg3: Allow WOL for phylib controlled Broadcom phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081103.165437.02556544.davem@davemloft.net>
Date:	Mon, 03 Nov 2008 16:54:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	afleming@...il.com
Cc:	mcarlson@...adcom.com, netdev@...r.kernel.org, mchan@...adcom.com,
	andy@...yhouse.net
Subject: Re: [PATCH 09/15] tg3: Allow WOL for phylib controlled Broadcom
 phys

From: "Andy Fleming" <afleming@...il.com>
Date: Mon, 3 Nov 2008 17:09:34 -0600

> On Mon, Nov 3, 2008 at 4:13 AM, Matt Carlson <mcarlson@...adcom.com> wrote:
> > This patch allows WOL to be enabled for Broadcom phys under phylib
> > control.  The only exception is the AC131, which has a completely
> > different register set.
> >
> > Signed-off-by: Matt Carlson <mcarlson@...adcom.com>
> > Signed-off-by: Michael Chan <mchan@...adcom.com>
> 
> Code to enable WOL sounds like the sort of thing we'd want in the PHY
> driver itself, rather than a manual setup done from the NIC driver.
> Clearly, we need support for WOL on both in order for it to work,
> though, so I can see two solutions off the top of my head:
 ...

I've applied Matt's patch, but I hope that you two will continue
the dialogue about this issue.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html