netdev - Re: [Bugme-new] [Bug 11865] New: WOL for E100 Doesn't Work Anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200811040031.46601.rjw@sisk.pl>
Date:	Tue, 4 Nov 2008 00:31:45 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"bugme-daemon@...zilla.kernel.org" <bugme-daemon@...zilla.kernel.org>,
	"rogerx@....lonestar.org" <rogerx@....lonestar.org>
Subject: Re: [Bugme-new] [Bug 11865] New: WOL for E100 Doesn't Work Anymore

On Monday, 3 of November 2008, Brandeburg, Jesse wrote:
> Andrew Morton wrote:
> > (switched to email.  Please respond via emailed reply-to-all, not via
> > the bugzilla web interface).
> > 
> > On Sun, 26 Oct 2008 21:56:35 -0700 (PDT)
> > bugme-daemon@...zilla.kernel.org wrote: 
> > 
> >> http://bugzilla.kernel.org/show_bug.cgi?id=11865
> >> 
> >>            Summary: WOL for E100 Doesn't Work Anymore           
> >>            Product: Drivers Version: 2.5
> >>      KernelVersion: 2.6.27
> >>           Platform: All
> >>         OS/Version: Linux
> >>               Tree: Mainline
> >>             Status: NEW
> >>           Severity: normal
> >>           Priority: P1
> >>          Component: Network
> >>         AssignedTo: jgarzik@...ox.com
> >>         ReportedBy: rogerx@....lonestar.org
> >> 
> >> 
> >> Latest working kernel version: 2.6.27
> > 
> > This should read 2.6.26.  It is a regression.
> > 
> >> Earliest failing kernel version: 2.6.27
> >> Distribution: Gentoo
> >> Hardware Environment: 2x750P3 1G RAM w/
> >> 
> >> 00:14.0 Ethernet controller: Intel Corporation 82557/8/9 [Ethernet
> >> Pro 100] (rev 08) 
> >> 
> >> Problem Description:
> >> As of kernel version 2.6.27, WOL has stopped working.  The box no
> >> longer powers on after the magic packet has been sent.  Rebooting
> >> using kernel-2.6.26*, WOL *does* work! 
> 
> what does cat /proc/acpi/wakeup say?  (if you have legacy acpi procfs)
> 
> >> 
> >> Steps to reproduce:
> >> (Not needed.  Self Explanatory.)
> >> 
> >> 
> >> I noticed 3 lines of code in e100.c added/modified since 2.6.26*,
> >> however, I reversed 2 lines of code to 2.6.26 and the other line was
> >> just added an additional pointer, for which I left alone. 
> >> Recompiled, rebooted and WOL still didn't work using 2.6.27.  I'm
> >> guessing, the source of this bug lies elsewhere. 
> 
> I think there is an outstanding patch set to "make device use the new
> power management api"
> http://marc.info/?l=linux-netdev&m=121874992800468&w=2

There were three patches like this, one against sky2 and the others for e100
and skge.  The sky2 one has been merged, the other two are in the Jeff's tree
AFAICS.

> It doesn't appear this patch was in 2.6.27, I'm not sure why not, but I
> am relatively afraid that lots of devices ability to wake up got busted
> in 2.6.27.

Well, unfortunately the maintainers of the networking code were not very
interested in these patches, although I had sent them well before 2.6.27
for the first time.

Generally, the sky2 commit at
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9d731d77c9794bb0a264f58d35949a1ab6dcc41c
illustrates what needs to be done for other NICs supporting WOL (the key part
is to call device_set_wakeup_enable() with appropriate arguments whenever
WOL is enabled/disabled and using for the initialization).

I'm going to do this over time for all of the drivers, but if anyone can help,
please do so.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html