netdev - RE: [Bugme-new] [Bug 11865] New: WOL for E100 Doesn't Work Anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F169D4F5E1F1974DBFAFABF47F60C10A0E873FEB@orsmsx507.amr.corp.intel.com>
Date:	Mon, 3 Nov 2008 16:47:59 -0800
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>,
	David Miller <davem@...emloft.net>,
	"jeff@...zik.org" <jeff@...zik.org>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"bugme-daemon@...zilla.kernel.org" <bugme-daemon@...zilla.kernel.org>,
	"rogerx@....lonestar.org" <rogerx@....lonestar.org>
Subject: RE: [Bugme-new] [Bug 11865] New: WOL for E100 Doesn't Work Anymore

Rafael J. Wysocki wrote:
>>>> 00:14.0 Ethernet controller: Intel Corporation 82557/8/9 [Ethernet
>>>> Pro 100] (rev 08) 
>>>> 
>>>> Problem Description:
>>>> As of kernel version 2.6.27, WOL has stopped working.  The box no
>>>> longer powers on after the magic packet has been sent.  Rebooting
>>>> using kernel-2.6.26*, WOL *does* work!

>> I think there is an outstanding patch set to "make device use the
>> new power management api"
>> http://marc.info/?l=linux-netdev&m=121874992800468&w=2 
> 
> There were three patches like this, one against sky2 and the others
> for e100 and skge.  The sky2 one has been merged, the other two are
> in the Jeff's tree AFAICS.

why did you pick those three drivers?  I'm glad you picked e100 as one
of the ones to make the change to, but there are a lot of other drivers
that support wake on lan, and are probably now broken.

>> It doesn't appear this patch was in 2.6.27, I'm not sure why not,
>> but I am relatively afraid that lots of devices ability to wake up
>> got busted in 2.6.27.
> 
> Well, unfortunately the maintainers of the networking code were not
> very interested in these patches, although I had sent them well
> before 2.6.27 
> for the first time.

unless I am mistaken the reason we have drivers in the kernel is that so
when API changes are made to the kernel the driver is pulled along with
it.  As I understand it, your changes to the core API should have been
rejected until the drivers that used power management APIs were updated
too, otherwise we just get generic user breakage.

Would you have asked for our help directly (CC:) we probably can/could
help with our drivers.

> Generally, the sky2 commit at
>
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
t;h=9d731d77c9794bb0a264f58d35949a1ab6dcc41c
> illustrates what needs to be done for other NICs supporting WOL (the
> key part is to call device_set_wakeup_enable() with appropriate
> arguments whenever 
> WOL is enabled/disabled and using for the initialization).
> 
> I'm going to do this over time for all of the drivers, but if anyone
> can help, please do so.

While that is a worthy goal, I don't think it is okay to have
regressions until you have time to fix them.  This is a pretty big
change in a subtly difficult area to both get right and to test.

Your work is appeciated, I just didn't realize it would break all
devices that didn't implement it.

I'm open to corrections to my point of view above.
Jesse

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6703 bytes)