netdev - Re: [PATCH] virtio_net: don't set NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1225968974.7284.17.camel@blaa>
Date:	Thu, 06 Nov 2008 10:56:14 +0000
From:	Mark McLoughlin <markmc@...hat.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>, netdev@...r.kernel.org
Subject: Re: [PATCH] virtio_net: don't set NETIF_F_FRAGLIST

On Thu, 2008-11-06 at 05:48 -0500, Jeff Garzik wrote:
> Mark McLoughlin wrote:
> > On Thu, 2008-11-06 at 00:43 -0500, Jeff Garzik wrote:
> >> Mark McLoughlin wrote:
> >>> We don't handle skb_shared_info->frag_list, so we shouldn't
> >>> be setting the NETIF_F_FRAGLIST flag.
> >>>
> >>> Signed-off-by: Mark McLoughlin <markmc@...hat.com>
> >>> ---
> >>>  drivers/net/virtio_net.c |    2 +-
> >>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> >>> index 0196a0d..9d4fdad 100644
> >>> --- a/drivers/net/virtio_net.c
> >>> +++ b/drivers/net/virtio_net.c
> >>> @@ -505,7 +505,7 @@ static int virtnet_probe(struct virtio_device *vdev)
> >>>  	/* Do we support "hardware" checksums? */
> >>>  	if (csum && virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) {
> >>>  		/* This opens up the world of extra features. */
> >>> -		dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
> >>> +		dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG;
> >>>  		if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) {
> >>>  			dev->features |= NETIF_F_TSO | NETIF_F_UFO
> >>>  				| NETIF_F_TSO_ECN | NETIF_F_TSO6;
> >> applied this and tun patch
> > 
> > Sorry Jeff, Rusty correctly points out that we do in fact handle
> > shinfo->frags; just a moment of blindness on my part.
> 
> but what about frag_list ?

Yeah, I meant shinfo->frag_list.

virtio_net uses skb_to_sgvec() and tun uses skb_copy_datagram_iovec()

Both handle shinfo->frag_list correctly.

Thanks,
Mark.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html