netdev - Re: [PATCH] SSB: make it depend on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225969620.3619.204.camel@johannes.berg>
Date:	Thu, 06 Nov 2008 12:07:00 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Mike Frysinger <vapier@...too.org>
Cc:	Michael Buesch <mb@...sch.de>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] SSB: make it depend on PCI

On Thu, 2008-11-06 at 04:51 -0500, Mike Frysinger wrote:
> Since the SSB code requires PCI, set the Kconfig dependencies accordingly.
> Also tweak the menu display so that the menu does not show up at all if
> SSB is not possible.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  drivers/ssb/Kconfig |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> index 307b1f6..f0a176a 100644
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -1,10 +1,11 @@
> -menu "Sonics Silicon Backplane"
> -
>  config SSB_POSSIBLE
>  	bool
> -	depends on HAS_IOMEM && HAS_DMA
> +	depends on HAS_IOMEM && HAS_DMA && PCI

This is incorrect. SSB is also used on embedded systems that do not use
PCI at all.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)