[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2008 03:33:45 -0500
From: Jeff Garzik <jeff@...zik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC: netdev@...r.kernel.org, davem@...emloft.net,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH] ixgbe: Fix usage of netif_*_all_queues() with netif_carrier_{off|on}()
Jeff Kirsher wrote:
> From: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
>
> netif_carrier_off() is sufficient to stop Tx into the driver. Stopping the Tx
> queues is redundant and unnecessary. By the same token, netif_carrier_on()
> will be sufficient to re-enable Tx, so waking the queues is unnecessary.
Is this a fix as the subject says (2.6.28), or an optimization as the
description implies (2.6.29)?
AFAICS from a quick glance, things are not actually _broken_, are they?
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists