netdev - Re: Validation of DMA params breaks e100 driver (2.6.28-rc2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081113.184225.113857300.davem@davemloft.net>
Date:	Thu, 13 Nov 2008 18:42:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jesse.brandeburg@...el.com
Cc:	linux@....linux.org.uk, grfstrm@...rs.sourceforge.net,
	linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: Validation of DMA params breaks e100 driver (2.6.28-rc2)

From: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Date: Thu, 13 Nov 2008 17:21:50 -0800 (Pacific Standard Time)

> On Fri, 31 Oct 2008, Russell King - ARM Linux wrote:
> 
> > On Thu, Oct 30, 2008 at 05:27:59PM +0100, Anders Grafström wrote:
> > > The e100 driver triggers BUG_ON(buf->direction != dir)
> > > by doing pci_map_single(..., PCI_DMA_BIDIRECTIONAL)
> > > and pci_dma_sync_single_for_device(..., PCI_DMA_TODEVICE).
> > > 
> > > I'm guessing it's allowed to do that and that something like
> > > the patch below is called for?
> > 
> > No, it is not allowed to do that - that's why it's called "BUG_ON".
> > Changing the DMA direction, especially with dmabounce will result
> > in unexpected behaviour.
> 
> okay, how about this patch...  only compile tested as I couldn't get 
> net-next-2.6 to boot on my test machine.  I'll get some testing done on 
> this, but in the meantime....
> 
> e100: fix dma error in direction for mapping
> 
> From: Jesse Brandeburg <jesse.brandeburg@...el.com>

FWIW this looks good to me.

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html