netdev - RE: Validation of DMA params breaks e100 driver (2.6.28-rc2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F169D4F5E1F1974DBFAFABF47F60C10A0EB53E2A@orsmsx507.amr.corp.intel.com>
Date:	Fri, 14 Nov 2008 14:30:41 -0800
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	Anders Grafström <grfstrm@...rs.sourceforge.net>
CC:	Russell King - ARM Linux <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.arm.linux.org.uk" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: RE: Validation of DMA params breaks e100 driver (2.6.28-rc2)

Anders Grafström wrote:
> Brandeburg, Jesse wrote:
>> On Fri, 31 Oct 2008, Russell King - ARM Linux wrote:
>>
>>> On Thu, Oct 30, 2008 at 05:27:59PM +0100, Anders Grafström wrote:
>>>> The e100 driver triggers BUG_ON(buf->direction != dir)
>>>> by doing pci_map_single(..., PCI_DMA_BIDIRECTIONAL)
>>>> and pci_dma_sync_single_for_device(..., PCI_DMA_TODEVICE).
>>>>
>>>> I'm guessing it's allowed to do that and that something like
>>>> the patch below is called for?
>>> No, it is not allowed to do that - that's why it's called "BUG_ON".
>>> Changing the DMA direction, especially with dmabounce will result
>>> in unexpected behaviour.
>>
>> okay, how about this patch...  only compile tested as I couldn't get
>> net-next-2.6 to boot on my test machine.  I'll get some testing done
>> on this, but in the meantime....
>>
>> e100: fix dma error in direction for mapping
>>
>> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
>
> I failed to save this patch (flowed format?) but I applied it manually
> to 2.6.28-rc4 and tried it. Appears to work.

Strange... sorry for the thrash on the patch, and thanks for testing!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html