netdev - Re: [PATCH] scm: fix scm_fp_list->list initialization made in wrong place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081114.145218.125819122.davem@davemloft.net>
Date:	Fri, 14 Nov 2008 14:52:18 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] scm: fix scm_fp_list->list initialization made in
 wrong place

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Fri, 14 Nov 2008 17:32:58 +0300

> This is the next page of the scm recursion story (the commit 
> f8d570a4 net: Fix recursive descent in __scm_destroy()).
> 
> In function scm_fp_dup(), the INIT_LIST_HEAD(&fpl->list) of newly
> created fpl is done *before* the subsequent memcpy from the old 
> structure and thus the freshly initialized list is overwritten.
> 
> But that's OK, since this initialization is not required at all,
> since the fpl->list is list_add-ed at the destruction time in any
> case (and is unused in other code), so I propose to drop both
> initializations, rather than moving it after the memcpy.
> 
> Please, correct me if I miss something significant.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Yep, this is totally correct.

Linus even noticed this in my original patch but kept them there
because they seemed harmless to him.

Patch applied to net-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html