netdev - Re: rtnetlink: propagate error from dev_change_flags in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Nov 2008 14:16:08 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>, Patrick McHardy <kaber@...sh.net>
Subject: Re: rtnetlink: propagate error from dev_change_flags in
	do_setlink()

On Sun, 2008-11-16 at 14:10 +0100, Johannes Berg wrote:
> Unlike ifconfig, iproute doesn't report an error when setting
> an interface up fails:
> 
> (example: put wireless network mac80211 interface into repeater mode
> with iwconfig but do not set a peer MAC address, it should fail with
> -ENOLINK)
> 
> without patch:
> # ip link set wlan0 up ; echo $?
> 0
> # 
> 
> with patch:
> # ip link set wlan0 up ; echo $?
> RTNETLINK answers: Link has been severed
> 2
> # 
> 
> Propagate the return value from dev_change_flags() to fix this.
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>
> Tested-by: Johannes Berg <johannes@...solutions.net>
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

Maybe add
Cc: stable@...nel.org [since the beginning of time^Wgit]

when committing? Not sure it's appropriate for stable since so far
nobody complained, I suspect people just use the ioctl anyway.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)