netdev - Re: rtnetlink: propagate error from dev_change_flags in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081116.232100.91284662.davem@davemloft.net>
Date:	Sun, 16 Nov 2008 23:21:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: rtnetlink: propagate error from dev_change_flags in
 do_setlink()

From: Johannes Berg <johannes@...solutions.net>
Date: Sun, 16 Nov 2008 14:16:08 +0100

> On Sun, 2008-11-16 at 14:10 +0100, Johannes Berg wrote:
> > Unlike ifconfig, iproute doesn't report an error when setting
> > an interface up fails:
> > 
> > (example: put wireless network mac80211 interface into repeater mode
> > with iwconfig but do not set a peer MAC address, it should fail with
> > -ENOLINK)
> > 
> > without patch:
> > # ip link set wlan0 up ; echo $?
> > 0
> > # 
> > 
> > with patch:
> > # ip link set wlan0 up ; echo $?
> > RTNETLINK answers: Link has been severed
> > 2
> > # 
> > 
> > Propagate the return value from dev_change_flags() to fix this.
> > 
> > Signed-off-by: Patrick McHardy <kaber@...sh.net>
> > Tested-by: Johannes Berg <johannes@...solutions.net>
> > Signed-off-by: Johannes Berg <johannes@...solutions.net>

Patch applied.

> Maybe add
> Cc: stable@...nel.org [since the beginning of time^Wgit]
> 
> when committing? Not sure it's appropriate for stable since so far
> nobody complained, I suspect people just use the ioctl anyway.

I'll queue it up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html