netdev - Re: [PATCH] ixgbe: fix compilation with gcc-3.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Nov 2008 11:26:46 -0800 (Pacific Standard Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] ixgbe: fix compilation with gcc-3.4


On Mon, 17 Nov 2008, Alexey Dobriyan wrote:

>   CC [M]  drivers/net/ixgbe/ixgbe_main.o
> drivers/net/ixgbe/ixgbe_main.c: In function `ixgbe_intr':
> drivers/net/ixgbe/ixgbe_main.c:1290: sorry, unimplemented: inlining failed in call to 'ixgbe_irq_enable': function body not available
> drivers/net/ixgbe/ixgbe_main.c:1312: sorry, unimplemented: called from here
> make[4]: *** [drivers/net/ixgbe/ixgbe_main.o] Error 1
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>  drivers/net/ixgbe/ixgbe_main.c |   58 +++++++++++++++++++----------------------
>  1 file changed, 28 insertions(+), 30 deletions(-)
> 
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -1287,7 +1287,34 @@ static void ixgbe_set_itr(struct ixgbe_adapter *adapter)
>  	return;
>  }
>  
> -static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter);
> +/**
> + * ixgbe_irq_disable - Mask off interrupt generation on the NIC
> + * @adapter: board private structure
> + **/
> +static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter)
> +{
> +	IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, ~0);
> +	IXGBE_WRITE_FLUSH(&adapter->hw);
> +	if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) {
> +		int i;
> +		for (i = 0; i < adapter->num_msix_vectors; i++)
> +			synchronize_irq(adapter->msix_entries[i].vector);
> +	} else {
> +		synchronize_irq(adapter->pdev->irq);
> +	}
> +}
> +
> +/**
> + * ixgbe_irq_enable - Enable default interrupt generation settings
> + * @adapter: board private structure
> + **/
> +static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter)
> +{
> +	u32 mask;
> +	mask = IXGBE_EIMS_ENABLE_MASK;
> +	IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask);
> +	IXGBE_WRITE_FLUSH(&adapter->hw);
> +}
>  
>  /**
>   * ixgbe_intr - legacy mode Interrupt Handler
> @@ -1394,35 +1421,6 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter)
>  }
>  
>  /**
> - * ixgbe_irq_disable - Mask off interrupt generation on the NIC
> - * @adapter: board private structure
> - **/
> -static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter)
> -{
> -	IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, ~0);
> -	IXGBE_WRITE_FLUSH(&adapter->hw);
> -	if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) {
> -		int i;
> -		for (i = 0; i < adapter->num_msix_vectors; i++)
> -			synchronize_irq(adapter->msix_entries[i].vector);
> -	} else {
> -		synchronize_irq(adapter->pdev->irq);
> -	}
> -}
> -
> -/**
> - * ixgbe_irq_enable - Enable default interrupt generation settings
> - * @adapter: board private structure
> - **/
> -static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter)
> -{
> -	u32 mask;
> -	mask = IXGBE_EIMS_ENABLE_MASK;
> -	IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask);
> -	IXGBE_WRITE_FLUSH(&adapter->hw);
> -}
> -
> -/**
>   * ixgbe_configure_msi_and_legacy - Initialize PIN (INTA...) and MSI interrupts
>   *
>   **/
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>

-PJ Waskiewicz
<peter.p.waskiewicz.jr@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html