netdev - Re: [PATCH] net: Cleanup of af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <492121DD.9030505@cosmosbay.com>
Date:	Mon, 17 Nov 2008 08:48:45 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Joe Perches <joe@...ches.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Cleanup of af_unix

Joe Perches a écrit :
> On Mon, 2008-11-17 at 07:46 +0100, Eric Dumazet wrote:
>> [PATCH] net: Cleanup of af_unix
>>
>> This is a pure cleanup of net/unix/af_unix.c to meet current code style standards
>>
>> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
>> --- 
>>  net/unix/af_unix.c |  117 ++++++++++++++++++++-----------------------
>>  1 files changed, 55 insertions(+), 62 deletions(-)
>> plain text document attachment (af_unix_cleanup.patch)
>> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
>> index 4a39771..58db2a2 100644
>> --- a/net/unix/af_unix.c
>> +++ b/net/unix/af_unix.c
>> @@ -354,7 +353,7 @@ static void unix_sock_destructor(struct sock *sk)
>>  	WARN_ON(!sk_unhashed(sk));
>>  	WARN_ON(sk->sk_socket);
>>  	if (!sock_flag(sk, SOCK_DEAD)) {
>> -		printk("Attempt to release alive unix socket: %p\n", sk);
>> +		printk(KERN_DEBUG "Attempt to release alive unix socket: %p\n", sk);
>>  		return;
>>  	}
>>  
> 
> Well, perhaps not quite pure.
> The KERN_ level selection is debatable.
> This could or perhaps should be KERN_INFO.

I agree. I was fooled by the next lines doing :

printk(KERN_DEBUG "UNIX %p is destroyed, %d are still alive.\n", sk,
	atomic_read(&unix_nr_socks));

   



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html