netdev - Re: [PATCH net-next v2]netdevice: 82596: Convert netdev->priv to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <492182C8.6060704@cn.fujitsu.com>
Date:	Mon, 17 Nov 2008 22:42:16 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	David Miller <davem@...emloft.net>
CC:	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2]netdevice: 82596: Convert netdev->priv to
 netdev_priv

David Miller said the following on 2008-11-17 17:29:
> From: Wang Chen <wangchen@...fujitsu.com>
> Date: Mon, 17 Nov 2008 17:24:38 +0800
> 
>> The memory, which pointed by netdev->priv, can be allocated by alloc_etherdev().
>> We don't need to use __get_free_pages() to get memory.
>>
>> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> 
> I don't think this is right either.
> 
> There might be device imposed alignment constraints, for example.
> 
> And a whole page is also being allocated so that this cache mode
> change doesn't have an effect on unrelated kernel memory.  That could
> kill performance if some critical other data structure sits in the
> same page and now has it's cacheability disabled.
> 

On this situation, I think that keeping mem_start and using ml_priv
is the only way to remove directly reference of netdev->priv.

I will send v3 tomorrow.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html