netdev - Re: [PATCH] net: make ip_rt_acct a normal percpu var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Nov 2008 02:08:10 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: make ip_rt_acct a normal percpu var

On Tuesday 18 November 2008 09:06:14 Eric Dumazet wrote:
> Rusty Russell a écrit :
> > There's no reason for this to be dynamically allocated: we panic if
> > allocation fails anyway.
> >
> > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
>
> Well, since we dont have "per_cpu bss", this also grow the size of vmlinux
> file, with a block of 4096 nul bytes.
...
> Maybe with current machines/boot loaders, we dont care anymore, I dont
> know...

Good q.  If people care about on-disk size, maybe we should look at bzImage 
size?

Anyway, here 'tis:
Before:
  text    data     bss     dec     hex filename
4116153  433292  475136 5024581  4cab45 vmlinux
-rw-r--r-- 1 rusty rusty 2251984 2008-11-19 02:03 arch/x86/boot/bzImage

After:
   text    data     bss     dec     hex filename
4116089  437388  475136 5028613  4cbb05 vmlinux
-rw-r--r-- 1 rusty rusty 2252016 2008-11-19 02:05 arch/x86/boot/bzImage

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html