netdev - Re: [PATCH] net: make ip_rt_acct a normal percpu var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081119.142023.117741600.davem@davemloft.net>
Date:	Wed, 19 Nov 2008 14:20:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	rusty@...tcorp.com.au
Cc:	dada1@...mosbay.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: make ip_rt_acct a normal percpu var

From: Rusty Russell <rusty@...tcorp.com.au>
Date: Wed, 19 Nov 2008 02:08:10 +1030

> On Tuesday 18 November 2008 09:06:14 Eric Dumazet wrote:
> > Rusty Russell a écrit :
> > > There's no reason for this to be dynamically allocated: we panic if
> > > allocation fails anyway.
> > >
> > > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> >
> > Well, since we dont have "per_cpu bss", this also grow the size of vmlinux
> > file, with a block of 4096 nul bytes.
> ...
> > Maybe with current machines/boot loaders, we dont care anymore, I dont
> > know...
> 
> Good q.  If people care about on-disk size, maybe we should look at bzImage 
> size?

It's the size of the final uncompressed loaded image that matters for
some bootloader limits.

I really don't like anything that increases the size like this, to be
honest.

Do you really need this to forward some work you are doing?  If not
can we just let sleeping dogs lie on this one? :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html