netdev - Re: [PATCH-2.6.28] net: jme.c rxdesc.flags is _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081119.155110.213037648.davem@davemloft.net>
Date:	Wed, 19 Nov 2008 15:51:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	cooldavid@...ldavid.org, netdev@...r.kernel.org
Subject: Re: [PATCH-2.6.28] net: jme.c rxdesc.flags is __le16, other
 missing endian swaps

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Mon, 17 Nov 2008 13:30:05 -0800

> This is the minimal patch to fix endian mismatches.  These are
> probably bugs on big-endian arches, noops on little endian.
> 
> jme_rxsum_ok could be improved to directly take a __le16 and
> change all of the masks/sets to be in little-endian, but
> has not been done here to keep the patch small.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
> Dave, could use confirmation here, but looks almost certainly like a bugfix
> for big-endian.

This looks good, applied, thanks Harvey.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html