netdev - Re: [PATCH] phylib: Fix auto-negotiation restart avoidance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081119.155217.234975526.davem@davemloft.net>
Date:	Wed, 19 Nov 2008 15:52:17 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	tpiepho@...escale.com
Cc:	netdev@...r.kernel.org, scottwood@...escale.com,
	afleming@...escale.com
Subject: Re: [PATCH] phylib: Fix auto-negotiation restart avoidance

From: Trent Piepho <tpiepho@...escale.com>
Date: Mon, 17 Nov 2008 13:33:25 -0800

> A previous patch, 51e2a3846eab18711f4eb59cd0a4c33054e2980a, made
> genphy_config_aneg() not restart aneg by calling genphy_restart_aneg() if
> the advertisement hadn't changed.
> 
> But, genphy_restart_aneg() doesn't just restart aneg, it may also *enable*
> aneg or un-isolate the PHY from the MII (those functions are controlled by
> the same register).  The code to avoid calling genphy_restart_aneg() didn't
> consider this.
> 
> So, modify genphy_config_aneg() to also check if the PHY needs to have aneg
> enabled or be un-isolated before deciding not to restart aneg.
> 
> This caused a problem with certain Davicom PHYs, as that driver isolates
> the PHY (why?) before calling genphy_config_aneg() and expects the PHY to
> be un-isolated by that function.
> 
> Signed-off-by: Trent Piepho <tpiepho@...escale.com>
> Reported-by: Scott Wood <scottwood@...escale.com>
> CC: Andy Fleming <afleming@...escale.com>
> ---
> This fixes a 2.6.28 regression.

I'll apply this, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html