netdev - Re: [NET-NEXT v3 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081120.004400.244258277.davem@davemloft.net>
Date:	Thu, 20 Nov 2008 00:44:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, jeff@...zik.org,
	alexander.h.duyck@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [NET-NEXT v3 PATCH 1/5] ixgbe: this patch adds support for DCB
 to the kernel and ixgbe driver

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon, 17 Nov 2008 17:00:43 -0800

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This adds support for Data Center Bridging (DCB) features in the ixgbe driver and adds an rtnetlink interface for configuring DCB to the kernel.  The DCB feature support included are Priority Grouping (PG) - which allows bandwidth guarantees to be allocated to groups to traffic based on the 802.1q priority, and Priority Based Flow Control (PFC) - which introduces a new MAC control PAUSE frame which works at granularity of the 802.1p priority instead of the link (IEEE 802.3x).
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>

I appreciate your effort Jeff, but the idea was to minimize the
number of ifdefs in *.c files, not increase them.

Please make it so that stuff like this isn't scattered all over existing
driver source files.

> @@ -2271,15 +2333,39 @@ static void ixgbe_set_num_queues(struct ixgbe_adapter *adapter)
>  {
>  	int nrq = 1, ntq = 1;
>  	int feature_mask = 0, rss_i, rss_m;
> +#ifdef CONFIG_IXGBE_DCBNL
> +	int dcb_i, dcb_m;
> +#endif
>  
>  	/* Number of supported queues */
>  	switch (adapter->hw.mac.type) {
>  	case ixgbe_mac_82598EB:

And all of the cases like the following is really needing a fixup:

> +#ifdef CONFIG_IXGBE_DCBNL
> +static int ixgbe_alloc_queues(struct ixgbe_adapter *adapter)
> +#else
>  static int __devinit ixgbe_alloc_queues(struct ixgbe_adapter *adapter)
> +#endif

Thanks :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html