netdev - Re: [RFC] question about inet_listen_lock(), and [PATCH] net: listening

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081120.004103.45482570.davem@davemloft.net>
Date:	Thu, 20 Nov 2008 00:41:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] question about inet_listen_lock(), and [PATCH] net:
 listening_hash get a spinlock per bucket

From: Eric Dumazet <dada1@...mosbay.com>
Date: Mon, 17 Nov 2008 17:21:19 +0100

> [PATCH] net: listening_hash get a spinlock per bucket
> 
> This patch prepares RCU migration of listening_hash table for
> TCP/DCCP protocols.
> 
> listening_hash table being small (32 slots per protocol), we add
> a spinlock for each slot, instead of a single rwlock for whole table.
> 
> This should reduce hold time of readers, and writers concurrency.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Ok it looks indeed as this sleeping thing was just a queer way to wait
when there was some thread dumping listening sockets.  I guess it must
have been _really_ slow back when that was written by Alexey :)

I've applied your patch to net-next-2.6, thanks Eric!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html