netdev - Re: [PATCH] netfilter: nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Nov 2008 13:59:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	fengguang.wu@...el.com
Cc:	kaber@...sh.net, linux-net@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_sctp: fix build warning

From: Wu Fengguang <fengguang.wu@...el.com>
Date: Sun, 23 Nov 2008 19:33:15 +0800

linux-net is not the mailing list for network development
discussion, it is for user questions.  Post patches and
developer questions to netdev@...r.kernel.org instead.

> net/netfilter/nf_conntrack_proto_sctp.c: In function ‘sctp_packet’:
> net/netfilter/nf_conntrack_proto_sctp.c:376: warning: array subscript is above array bounds
> 
> Signed-off-by: Wu Fengguang <wfg@...ux.intel.com>
> ---
> 
> DISCLAIMER: I'm newbie to the code, and this fix could be wrong!
> 
> diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c
> index ae8c260..d31ced4 100644
> --- a/net/netfilter/nf_conntrack_proto_sctp.c
> +++ b/net/netfilter/nf_conntrack_proto_sctp.c
> @@ -373,6 +373,9 @@ static int sctp_packet(struct nf_conn *ct,
>  	}
>  	write_unlock_bh(&sctp_lock);
>  
> +	if (new_state == SCTP_CONNTRACK_MAX)
> +		goto out;
> +
>  	nf_ct_refresh_acct(ct, ctinfo, skb, sctp_timeouts[new_state]);
>  
>  	if (old_state == SCTP_CONNTRACK_COOKIE_ECHOED &&
> --
> To unsubscribe from this list: send the line "unsubscribe linux-net" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html