| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b0438a630811240415n6a1a0b23lf7ac37925d04a6b3@mail.gmail.com>
Date: Mon, 24 Nov 2008 13:15:54 +0100
From: "Miguel Ángel Álvarez" <gotzoncabanes@...il.com>
To: "Krzysztof Halasa" <khc@...waw.pl>
Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: ixp4xx_hss MAX_CHAN_DEVICES
Hi
I show you here the first steps of the adding of a physical_mode
configuration for ixp4xx_hss. The changes are not complete at all, but
I wanted to send this just to get some initial impressions.
diff -urN linux-2.6.26.7_hssorig/arch/arm/mach-ixp4xx/ixdp425-setup.c
linux-2.6.26.7/arch/arm/mach-ixp4xx/ixdp425-setup.c
--- linux-2.6.26.7_hssorig/arch/arm/mach-ixp4xx/ixdp425-setup.c 2008-11-24
11:21:07.000000000 +0100
+++ linux-2.6.26.7/arch/arm/mach-ixp4xx/ixdp425-setup.c 2008-11-24
11:29:05.000000000 +0100
@@ -350,11 +350,13 @@
.open = hss_open,
.close = hss_close,
.txreadyq = 2,
+ .physical_mode = IXP4XX_HSS_4_E1,
}, {
.set_clock = hss_set_clock,
.open = hss_open,
.close = hss_close,
.txreadyq = 19,
+ .physical_mode = IXP4XX_HSS_4_E1,
}
};
diff -urN linux-2.6.26.7_hssorig/drivers/net/wan/ixp4xx_hss.c
linux-2.6.26.7/drivers/net/wan/ixp4xx_hss.c
--- linux-2.6.26.7_hssorig/drivers/net/wan/ixp4xx_hss.c 2008-11-24
11:22:09.000000000 +0100
+++ linux-2.6.26.7/drivers/net/wan/ixp4xx_hss.c 2008-11-24
12:55:26.000000000 +0100
@@ -302,6 +302,7 @@
/* assigned channels, may be invalid with given frame length or mode */
u8 channels[MAX_CHANNELS];
int msg_count;
+ u8 phmode_pos;
};
/* NPE message structure */
@@ -388,6 +389,21 @@
HSS1_PKT_RXFREE0_QUEUE, HSS1_CHL_RXTRIG_QUEUE},
};
+struct physical_modes {
+ u8 id;
+ unsigned int frame_size;
+ unsigned int clock_rate;
+ u32 clock_config;
+};
+
+static const struct physical_modes phmodes[] = {
+ {IXP4XX_HSS_T1, 193, 1544000, CLK42X_SPEED_1544KHZ},
+ {IXP4XX_HSS_E1, 256, 2048000, CLK42X_SPEED_2048KHZ},
+ {IXP4XX_HSS_2_E1, 512, 4096000, CLK42X_SPEED_4096KHZ},
+ {IXP4XX_HSS_4_E1, 1024, 8192000, CLK42X_SPEED_8192KHZ},
+ {0, 256, 2048000, CLK42X_SPEED_2048KHZ}
+};
+
/*****************************************************************************
* utility functions
****************************************************************************/
@@ -624,7 +640,7 @@
msg.cmd = PORT_CONFIG_WRITE;
msg.hss_port = port->id;
msg.index = HSS_CONFIG_CLOCK_CR;
- msg.data32 = CLK42X_SPEED_2048KHZ /* FIXME */;
+ msg.data32 = phmodes[port->phmode_pos].clock_config;
hss_npe_send(port, &msg, "HSS_SET_CLOCK_CR");
memset(&msg, 0, sizeof(msg));
@@ -2459,6 +2475,7 @@
return -EINVAL; /* FIXME not yet supported */
}
+#if 0
static ssize_t show_frame_size(struct device *dev,
struct device_attribute *attr, char *buf)
{
@@ -2499,6 +2516,7 @@
spin_unlock_irqrestore(&npe_lock, flags);
return ret;
}
+#endif
static ssize_t show_frame_offset(struct device *dev,
struct device_attribute *attr, char *buf)
@@ -2635,7 +2653,7 @@
__ATTR(hdlc_chan, 0644, show_hdlc_chan, set_hdlc_chan),
__ATTR(clock_type, 0644, show_clock_type, set_clock_type),
__ATTR(clock_rate, 0644, show_clock_rate, set_clock_rate),
- __ATTR(frame_size, 0644, show_frame_size, set_frame_size),
+ //__ATTR(frame_size, 0644, show_frame_size, set_frame_size),
__ATTR(frame_offset, 0644, show_frame_offset, set_frame_offset),
__ATTR(loopback, 0644, show_loopback, set_loopback),
__ATTR(mode, 0644, show_mode, set_mode),
@@ -2651,6 +2669,7 @@
struct net_device *dev;
hdlc_device *hdlc;
int i, err;
+ struct physical_modes* mode;
if ((port = kzalloc(sizeof(*port), GFP_KERNEL)) == NULL)
return -ENOMEM;
@@ -2669,6 +2688,17 @@
goto err_plat;
}
+ i = 0;
+ mode = &phmodes[0];
+ while (mode->id != 0) {
+ if (mode->id == port->plat->physical_mode) {
+ port->phmode_pos = i;
+ break;
+ }
+ i++;
+ mode = &phmodes[i];
+ }
+
SET_NETDEV_DEV(dev, &pdev->dev);
hdlc = dev_to_hdlc(dev);
hdlc->attach = hss_hdlc_attach;
@@ -2678,8 +2708,8 @@
dev->do_ioctl = hss_hdlc_ioctl;
dev->tx_queue_len = 100;
port->clock_type = CLOCK_EXT;
- port->clock_rate = 2048000;
- port->frame_size = 256; /* E1 */
+ port->clock_rate = mode->clock_rate;
+ port->frame_size = mode->frame_size;
memset(port->channels, CHANNEL_UNUSED, sizeof(port->channels));
init_waitqueue_head(&port->chan_tx_waitq);
init_waitqueue_head(&port->chan_rx_waitq);
diff -urN linux-2.6.26.7_hssorig/include/asm-arm/arch-ixp4xx/platform.h
linux-2.6.26.7/include/asm-arm/arch-ixp4xx/platform.h
--- linux-2.6.26.7_hssorig/include/asm-arm/arch-ixp4xx/platform.h 2008-11-24
11:22:42.000000000 +0100
+++ linux-2.6.26.7/include/asm-arm/arch-ixp4xx/platform.h 2008-11-24
12:06:42.000000000 +0100
@@ -103,6 +103,11 @@
u8 hwaddr[6];
};
+#define IXP4XX_HSS_T1 0x10
+#define IXP4XX_HSS_E1 0x11
+#define IXP4XX_HSS_2_E1 0x21
+#define IXP4XX_HSS_4_E1 0x41
+
/* Information about built-in HSS (synchronous serial) interfaces */
struct hss_plat_info {
int (*set_clock)(int port, unsigned int clock_type);
@@ -110,6 +115,7 @@
void (*set_carrier_cb)(void *pdev, int carrier));
void (*close)(int port, void *pdev);
u8 txreadyq;
+ u8 physical_mode;
};
/*
I have some questions to continue the changes:
- How should all these changes interact with show_frame_size and set_frame_size?
- I am a bit lost with MAX_CHANNELS and MAX_CHAN_DEVICES... Which are
the differences between both?
- As MAX_CHANNELS and MAX_CHAN_DEVICES should not be set by defines, I
am going to alloc memory for chan_devices... I am going to do it in
init_one... Is it OK?.
My first intention for all this is to set HSS into MVIP mode and have
4 HDLC channels in a packetized mode.
- How could I set this MVIP mode?
- How could I interface with generic HDLC so that hss_hdlc_xmit sends
the data for each stream to a different FIFO?
Thanks
Miguel Ángel Álvarez
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists