netdev - Re: [PATCH] netfilter: nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2008 13:23:16 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Wu Fengguang <fengguang.wu@...el.com>
CC:	Wang Chen <wangchen@...fujitsu.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Netfilter Development Mailinglist 
	<netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH] netfilter: nf_conntrack_sctp: fix build warning

Wu Fengguang wrote:
>> print some debug info would be better?
> 
> Like this one?
> +		pr_debug("Empty sctp packet\n");
> 
> Fengguang
> ---
> netfilter: nf_conntrack_sctp: fix build warning
> 
> net/netfilter/nf_conntrack_proto_sctp.c: In function ‘sctp_packet’:
> net/netfilter/nf_conntrack_proto_sctp.c:376: warning: array subscript is above array bounds

The warning is bogus, so we don't need a pr_debug() there.
I've applied your first patch with an unlikely() added and
a comment stating that the warning is bogus.


View attachment "x" of type "text/plain" (1173 bytes)