netdev - Re: respin of hso patches for linux-2.6.28-rc6 hso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8AC8EE6D-6C6D-41D6-806E-68646549710C@holtmann.org>
Date:	Mon, 24 Nov 2008 17:49:34 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Denis Joseph Barrow <D.Barow@...ion.com>
Cc:	Linux USB kernel mailing list <linux-usb@...r.kernel.org>,
	Linux netdev Mailing list <netdev@...r.kernel.org>
Subject: Re: respin of hso patches for linux-2.6.28-rc6 hso_mutex.patch [patch 4/6]

Hi Denis,

> A new structure hso_mutex_table had to be declared statically
> & used as as hso_device mutex_lock(&serial->parent->mutex) etc
> is freed in hso_serial_open & hso_serial_close by kref_put while
> the mutex is still in use.
> This is a substantial change but should make the driver much stabler.
> Signed-off-by: Denis Joseph Barrow <D.Barow@...ion.com>
> ---
> Index: linux-2.6.28-rc6.patches/drivers/net/usb/hso.c
> ===================================================================
> --- linux-2.6.28-rc6.patches.orig/drivers/net/usb/hso.c	2008-11-24  
> 14:19:17.000000000 +0100
> +++ linux-2.6.28-rc6.patches/drivers/net/usb/hso.c	2008-11-24  
> 14:59:29.000000000 +0100
> @@ -230,6 +230,11 @@
> 	struct work_struct    retry_unthrottle_workqueue;
> };
>
> +struct hso_mutex_t {
> +	struct mutex mutex;
> +	u8 allocated;
> +};
> +
> struct hso_device {
> 	union {
> 		struct hso_serial *dev_serial;
> @@ -248,7 +253,7 @@
>
> 	struct device *dev;
> 	struct kref ref;
> -	struct mutex mutex;
> +	struct hso_mutex_t *mutex;
> };

this looks pretty ugly to me. Can we not find a more elegant way to  
solve this problem?   It might involve fixing or changing the TTY  
layer, but that is actually fine.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html