netdev - Re: respin of hso patches for linux-2.6.28-rc6 hso_close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081124165019.624ee996@lxorguk.ukuu.org.uk>
Date:	Mon, 24 Nov 2008 16:50:19 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Denis Joseph Barrow <D.Barow@...ion.com>,
	Linux USB kernel mailing list <linux-usb@...r.kernel.org>,
	Linux netdev Mailing list <netdev@...r.kernel.org>
Subject: Re: respin of hso patches for linux-2.6.28-rc6 hso_close_fix.patch
 [patch 2/6 ]

> > 	D1("Closing serial port");
> > +	if (serial == NULL || serial->magic != HSO_SERIAL_MAGIC) {
> > +		D1("invalid serial structure bailing out.\n");
> > +		return;
> > +	}
> 
> using !serial instead of serial == NULL would be better.

A lot of serial code uses == NULL and its just as clear IMHO.

A bigger concern would be the lack of refcounting. Really for 2.6.28 now
the refcount patches are in the direction should be refcounting the tty
objects at least.

I've got a pair of proposed patches I'll post for comment

Alan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html