netdev - Re: [BUILD_FAILURE] linux-next: 20081125 - 8390 network driver build fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <492C562E.9090302@oracle.com>
Date:	Tue, 25 Nov 2008 11:46:54 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	p_gortmaker@...oo.com, netdev@...r.kernel.org, mel@....ul.ie
Subject: Re: [BUILD_FAILURE] linux-next: 20081125 - 8390 network driver build
 fails

Alan Cox wrote:
>> The problem is that both 8390.c and 8390p.c #include lib8390.c
>> and when they are both linked to built-in drivers (not loadable
>> modules), the symbols in lib8390.c are duplicated.  I think.
> 
> And the symbols in question are static so are scoped within the file
> only. Thats why it looks to me as if someone has done "#define static" in
> another patch somewhere in -next.

Try again:

  LD      drivers/net/built-in.o
drivers/net/8390p.o: In function `ei_get_stats':
(.text+0x1050): multiple definition of `ei_get_stats'
drivers/net/8390.o:(.text+0xe20): first defined here
drivers/net/8390p.o: In function `ei_start_xmit':
(.text+0x1100): multiple definition of `ei_start_xmit'
drivers/net/8390.o:(.text+0xef0): first defined here
drivers/net/8390p.o: In function `ei_tx_timeout':
(.text+0xec0): multiple definition of `ei_tx_timeout'
drivers/net/8390.o:(.text+0xce0): first defined here
drivers/net/8390p.o: In function `ei_set_multicast_list':
(.text+0x1000): multiple definition of `ei_set_multicast_list'
drivers/net/8390.o:(.text+0xea0): first defined here
make[2]: *** [drivers/net/built-in.o] Error 1

and none of these functions is static in lib8390.c.

~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html