netdev - Re: respin of hso patches for linux-2.6.28-rc6 hso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081125.022246.102969955.davem@davemloft.net>
Date:	Tue, 25 Nov 2008 02:22:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	alan@...rguk.ukuu.org.uk
Cc:	D.Barow@...ion.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: respin of hso patches for linux-2.6.28-rc6 hso_mutex.patch
 [patch 4/6]

From: Alan Cox <alan@...rguk.ukuu.org.uk>
Date: Tue, 25 Nov 2008 10:20:43 +0000

> On Tue, 25 Nov 2008 00:34:27 -0800 (PST)
> David Miller <davem@...emloft.net> wrote:
> 
> > From: Denis Joseph Barrow <D.Barow@...ion.com>
> > Date: Mon, 24 Nov 2008 15:48:47 +0100
> > 
> > > A new structure hso_mutex_table had to be declared statically
> > > & used as as hso_device mutex_lock(&serial->parent->mutex) etc
> > > is freed in hso_serial_open & hso_serial_close by kref_put while
> > > the mutex is still in use.
> > > This is a substantial change but should make the driver much stabler.
> > > Signed-off-by: Denis Joseph Barrow <D.Barow@...ion.com>
> > 
> > Applied, but I had to fixup a lot of whitespace errors.
> 
> Dave - I don't put random network layer patches in the ttydev tree,
> please don't put random tty driver patches in the network tree. Those
> patches
> 
> a) are woefully inadequate
> b) will clash with the ttydev work which is where this belongs

I thought this was a network driver?

If so, this poor guy has respun these patches so many times
my head is spinning, and making him wait for one more procedural
thing is just a good way to deter yet another developer.

Most of these patches looked fine, is there a specific one I
should leave out?

I'm not leaving all of them out, most of them looked perfectly
fine and didn't do any "tty" stuff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html