| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081125104213.03b280c5@lxorguk.ukuu.org.uk> Date: Tue, 25 Nov 2008 10:42:13 +0000 From: Alan Cox <alan@...rguk.ukuu.org.uk> To: David Miller <davem@...emloft.net> Cc: D.Barow@...ion.com, linux-usb@...r.kernel.org, netdev@...r.kernel.org Subject: Re: respin of hso patches for linux-2.6.28-rc6 hso_mutex.patch [patch 4/6] > I thought this was a network driver? It's both, but the resource handling mess is on the tty side, and several of the chunks (modem control etc) directly hit the tty parts and will clash with other tty layer changes. > > If so, this poor guy has respun these patches so many times > my head is spinning, and making him wait for one more procedural > thing is just a good way to deter yet another developer. Well if you check the list I sent him a set of patches to review in response to his posting. Those patches implement proper tty side refcounting and have a chance of actually fixing the problems. > I'm not leaving all of them out, most of them looked perfectly > fine and didn't do any "tty" stuff. That patch series is a complete mix: 1, 3 and 6 are network 2 is a broken tty layer patch 4 is a broken tty layer patch 5 is an ok tty layer patch 5 will go into the tty tree 2 and 4 clash with the tty tree already and don't deal with the tty side locking at all sanely. So I've no problem with the network parts (1,3,6) going into the netdev tree but the other bits will make a mess if they do so. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists