netdev - ixp4xx_hss. Little bug in hss_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0438a630811260913t638343a4i5576292b367c5dc2@mail.gmail.com>
Date:	Wed, 26 Nov 2008 18:13:06 +0100
From:	"Miguel Ángel Álvarez" <gotzoncabanes@...il.com>
To:	netdev@...r.kernel.org, "Krzysztof Halasa" <khc@...waw.pl>
Subject: ixp4xx_hss. Little bug in hss_init_one

Hi

I have found that platform_set_drvdata is not correctly called if we
have an error in requesting npe. Am I right?

Signed-off-by: Miguel Ángel Álvarez (gotzoncabanes@...il.com)
---
--- ixp4xx_hss.c.orig	2008-11-19 11:26:54.000000000 +0100
+++ ixp4xx_hss.c.initone	2008-11-26 18:09:22.000000000 +0100
@@ -2698,8 +2698,8 @@
 	free_netdev(dev);
 err_plat:
 	npe_release(port->npe);
-	platform_set_drvdata(pdev, NULL);
 err_free:
+	platform_set_drvdata(pdev, NULL);
 	kfree(port);
 	return err;
 }

Thanks

Miguel Ángel Álvarez
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html