netdev - Re: ixp4xx_hss. Little bug in hss_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m38wqvznp4.fsf@maximus.localdomain>
Date:	Thu, 04 Dec 2008 21:32:07 +0100
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Miguel Ángel Álvarez <gotzoncabanes@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: ixp4xx_hss. Little bug in hss_init_one

Hi,

"Miguel Ángel Álvarez" <gotzoncabanes@...il.com> writes:

> I have found that platform_set_drvdata is not correctly called if we
> have an error in requesting npe. Am I right?

Definitely. Though I will just move platform_set_drvdata() past
npe_request() (and register_hdlc_device()).

Thanks for spotting this bug.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html