netdev - Re: [PATCH 1/2] net: fix /proc/net/ip_mr_cache display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081203.222158.256869794.davem@davemloft.net>
Date:	Wed, 03 Dec 2008 22:21:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	benjamin.thery@...l.net
Cc:	netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH 1/2] net: fix /proc/net/ip_mr_cache display - V2

From: Benjamin Thery <benjamin.thery@...l.net>
Date: Wed, 03 Dec 2008 15:35:41 +0100

> /proc/net/ip_mr_cache and /proc/net/ip6_mr_cache displays garbage when
> showing unresolved mfc_cache entries.
> 
> [root@...u tests]# cat /proc/net/ip_mr_cache
> Group    Origin   Iif     Pkts    Bytes    Wrong Oifs
> 014C00EF 010014AC 1         10    10050        0  2:1    3:1
> 024C00EF 010014AC 65535      514        2 -559067475
> 
> The first line is correct. It is a resolved cache entry, 10 packets used it...
> The second line represents an unresolved entry, and the columns Pkts(4th),
> Bytes(5th) and Wrong(6th) just show garbage.
> 
> In struct mfc_cache, there's an union to store data for resolved and
> unresolved cases. And what ipmr_mfc_seq_show() is printing in these 
> columns for the unresolved entries is some bytes from mfc_cache.mfc_un.res.
> Bad.
> (eg. In our case -559067475 is in fact 0xdead4ead which is the spinlock
> magic from mfc_cache.mfc_un.unres.unresolved.lock.magic).
> 
> This patch replaces the garbage data written in these columns for the
> unresolved entries by '0' (zeros) which is more correct.
> This change doesn't break the ABI.
> 
> Also, mfc->mfc_un.res.pkt, mfc->mfc_un.res.bytes, mfc->mfc_un.res.wrong_if
> are unsigned long.
> 
> It applies on top of net-next-2.6.
> 
> The patch for net-2.6 is slightly different because of the NIP6_FMT to
> %pI6 conversion that was made in the seq_printf.
> 
> Changelog:
> ==========
> V2:
> * Instead of breaking the ABI by suppressing the columns that have no
>   meaning for unresolved entries, fill them with 0 values.
> 
> Signed-off-by: Benjamin Thery <benjamin.thery@...l.net>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html