netdev - Re: [PATCH 2/2] net: /proc/net/ip_mr_cache, display Iif as a signed short

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 03 Dec 2008 22:22:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	benjamin.thery@...l.net
Cc:	netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH 2/2] net: /proc/net/ip_mr_cache, display Iif as a
 signed short

From: Benjamin Thery <benjamin.thery@...l.net>
Date: Wed, 03 Dec 2008 15:35:42 +0100

> Today, iproute2 fails to show multicast forwarding unresolved cache
> entries while scanning /proc/net/ip_mr_cache.
> 
> Indeed, it expects to see -1 in 'Iif' column to identify unresolved
> entries but the kernel outputs 65535. It's a signed/unsigned issue:
> 
> 'Iif', the source interface, is retrieved from member mfc_parent in
> struct mfc_cache. mfc_parent is a vifi_t: unsigned short, but is
> displayed in ipmr_mfc_seq_show() as "%-3d", signed integer.
> 
> In unresolevd entries, the 65535 value (0xFFFF) comes from this define:
> #define ALL_VIFS    ((vifi_t)(-1))
> 
> That may explains why the guy who added support for this in iproute2
> thought a -1 should be expected.
> 
> I don't know if this must be fixed in kernel or in iproute2. Who is
> right? What is the correct API? How was it designed originally?
> 
> I let you decide if it should goes in the kernel or be fixed in iproute2.
> 
> Signed-off-by: Benjamin Thery <benjamin.thery@...l.net>

For now I think the kernel is the best place to handle this,
thus applied to net-next-2.6

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html