netdev - Re: [Patch] Micrel KS8695 intergrated ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 08 Dec 2008 12:29:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	dsilvers@...tec.co.uk, netdev@...r.kernel.org
Subject: Re: [Patch] Micrel KS8695 intergrated ethernet driver

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 08 Dec 2008 15:17:53 +0000

> On Mon, 2008-12-08 at 11:05 +0000, Daniel Silverstone wrote:
> [...]
> > > > +static inline struct ks8695_priv *
> > > > +ks8695_get_priv(struct net_device *ndev)
> > > Don't use ndev->priv, use netdev_priv(ndev).  Which makes this function
> > > redundant, except for the implicit pointer conversion.
> > 
> > Aah, I didn't know about that one, updated.
> 
> Until recently they have been equivalent by default; direct access to
> priv is now deprecated and it will be removed.

Not just "will be removed", but "is removed" in the current
net-next-2.6 tree so this driver wouldn't even compile :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html