netdev - Re: [PATCH] netpoll: fix race on poll_list resulting in garbage entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1229640015.2914.20.camel@hashbaz.i.decadent.org.uk>
Date:	Thu, 18 Dec 2008 22:40:15 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	David Miller <davem@...emloft.net>, shemminger@...tta.com,
	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] netpoll: fix race on poll_list resulting in garbage
	entry

On Thu, 2008-12-18 at 14:52 -0500, Neil Horman wrote:
[...]
> diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c
> index 086629c..75273bb 100644
> --- a/drivers/net/sfc/efx.c
> +++ b/drivers/net/sfc/efx.c
> @@ -226,11 +226,11 @@ static int efx_poll(struct napi_struct *napi, int budget)
>  
>  	if (rx_packets < budget) {
>  		/* There is no race here; although napi_disable() will
> -		 * only wait for netif_rx_complete(), this isn't a problem
> +		 * only wait for netif_rx_complete(this isn't a problem
>  		 * since efx_channel_processed() will have no effect if
>  		 * interrupts have already been disabled.
>  		 */
[...]

You'll want to exclude comments from your search-and-replace.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html