netdev - Re: [PATCH] netpoll: fix race on poll_list resulting in garbage entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1229643003.3601.58.camel@johannes.berg>
Date:	Fri, 19 Dec 2008 00:30:03 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Neil Horman <nhorman@...driver.com>,
	David Miller <davem@...emloft.net>, shemminger@...tta.com,
	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] netpoll: fix race on poll_list resulting in garbage
	entry

On Thu, 2008-12-18 at 22:40 +0000, Ben Hutchings wrote:

> >  	if (rx_packets < budget) {
> >  		/* There is no race here; although napi_disable() will
> > -		 * only wait for netif_rx_complete(), this isn't a problem
> > +		 * only wait for netif_rx_complete(this isn't a problem
> >  		 * since efx_channel_processed() will have no effect if
> >  		 * interrupts have already been disabled.
> >  		 */
> [...]
> 
> You'll want to exclude comments from your search-and-replace.

Or just use spatch (http://www.emn.fr/x-info/coccinelle/)

Should be as easy as:

@@
expression A, B;
@@
-netif_rx_schedule(A, B);
+netif_rx_schedule(B);

etc.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)