netdev - Re: [patch 08/10] 802.3ad: remove public lacpdu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081226.134537.212403770.davem@davemloft.net>
Date:	Fri, 26 Dec 2008 13:45:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	holger@...zenberger.org
Cc:	fubar@...ibm.com, netdev@...r.kernel.org
Subject: Re: [patch 08/10] 802.3ad: remove public lacpdu_header

From: David Miller <davem@...emloft.net>
Date: Fri, 26 Dec 2008 13:43:49 -0800 (PST)

> From: Holger Eitzenberger <holger@...zenberger.org>
> Date: Tue, 23 Dec 2008 23:01:09 +0100
> 
> > -	skb = dev_alloc_skb(length);
> > -	if (!skb) {
> > +	skb = dev_alloc_skb(len);
> > +	if (skb == NULL)
> 
> "!skb" is preferred to the long-winded "skb == NULL", so
> I'm tossing this patch and the rest which touch similar
> areas.

Also, I want to mention that your C++ comment conversions are not in
the proper coding style as well.  You are doing:

	/* something written
	   here */

instead of the proper:

	/* something written
	 * here
	 */

Just FYI...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html