[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20081229161541.GA19173@mail.eitzenberger.org>
Date: Mon, 29 Dec 2008 17:15:41 +0100
From: Holger Eitzenberger <holger@...zenberger.org>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org, fubar@...ibm.com
Subject: Re: [patch 08/10] 802.3ad: remove public lacpdu_header
On Fri, Dec 26, 2008 at 01:45:37PM -0800, David Miller wrote:
> > > - skb = dev_alloc_skb(length);
> > > - if (!skb) {
> > > + skb = dev_alloc_skb(len);
> > > + if (skb == NULL)
> >
> > "!skb" is preferred to the long-winded "skb == NULL", so
> > I'm tossing this patch and the rest which touch similar
> > areas.
>
> Also, I want to mention that your C++ comment conversions are not in
> the proper coding style as well. You are doing:
As I'm currently offline most of the time I'll resend once I'm back
home.
Thanks for your feedback!
/holger
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists