netdev - Re: [PATCH] hdlc: fix compile problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090107152858.6fb8ac5d@extreme>
Date:	Wed, 7 Jan 2009 15:28:58 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Krzysztof Halasa <khc@...waw.pl>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] hdlc: fix compile problem

On Thu, 08 Jan 2009 00:21:03 +0100
Krzysztof Halasa <khc@...waw.pl> wrote:

> Stephen Hemminger <shemminger@...tta.com> writes:
> 
> > Fix build problem with hdlc driver. hdlc_null_ops was being referenced
> > before it was defined!
> 
> :-)
> 
> Unfortunately I can't see it, which tree is it?
> 
> 
> In David's and Linus' trees it appears twice, it seem to be entirely
> correct and btw you are the author :-)
> ... and it compiled here 100 times or so :-)
> 
> static const struct header_ops hdlc_null_ops;
>                                ^^^^^^^^^^^^^
> static void hdlc_setup_dev(struct net_device *dev)
> {
>         /* Re-init all variables changed by HDLC protocol drivers,
>          * including ether_setup() called from hdlc_raw_eth.c.
>          */
>         dev->get_stats           = hdlc_get_stats;
>         dev->flags               = IFF_POINTOPOINT | IFF_NOARP;
>         dev->mtu                 = HDLC_MAX_MTU;
>         dev->type                = ARPHRD_RAWHDLC;
>         dev->hard_header_len     = 16;
>         dev->addr_len            = 0;
>         dev->header_ops          = &hdlc_null_ops;
>                                   ^^^^^^^^^^^^^^^^
>         dev->change_mtu          = hdlc_change_mtu;
> }

It was introduced (by me) in previous patch. Since that isn't applied yet,
I'll go back and fix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html