netdev - Re: [Bugme-new] [Bug 12327] New: Intermittent TCP issues with => 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090109031408.GB11336@gondor.apana.org.au>
Date:	Fri, 9 Jan 2009 14:14:08 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	John Dykstra <john.dykstra1@...il.com>
Cc:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>,
	Netdev <netdev@...r.kernel.org>,
	bugme-daemon@...zilla.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Speedster <speedster@...eacry.com>,
	Patrick McHardy <kaber@...sh.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Bugme-new] [Bug 12327] New: Intermittent TCP issues with =>
	2.6.27

On Thu, Jan 08, 2009 at 05:58:11PM -0600, John Dykstra wrote:
> 
> I haven't unscrambled where the drop occurs in the PPPoE driver, but that's
> presumably what changed in 2.6.27.  It seems to me that the drop is proper.
> What's wrong is trimming the sk_buff to match the IP header while ignoring
> the L2 header, and that's apparently been that way for a while (if I
> understand what the reporter is running where).
> 
> Or have I screwed up my first posting to netdev?

You've hit the nail on the head :)

The bridge netfilter is just one huge pile of crap that should
be deleted.

The least we should do is delete the VLAN/PPPOE parts of it because
it's simply bogus.  What if two VLANs/PPPOE sessions use the same
IP address pairs? They'll be treated as a single flow which is just
insane.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html