netdev - Re: [PATCH 1/4] virtio_net: Allow setting the MAC address of the NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1231947612.7109.267.camel@lappy>
Date:	Wed, 14 Jan 2009 08:40:12 -0700
From:	Alex Williamson <alex.williamson@...com>
To:	Mark McLoughlin <markmc@...hat.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>, kvm <kvm@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/4] virtio_net: Allow setting the MAC address of the
 NIC

On Wed, 2009-01-14 at 10:15 +0000, Mark McLoughlin wrote:
> On Tue, 2009-01-13 at 14:23 -0700, Alex Williamson wrote:
> 
> Commit log explaining why we need this.

Sorry, my commit logs are pretty weak across the board.  I'll update
them all.

> > +	} else {
> >  		random_ether_addr(dev->dev_addr);
> > +		vdev->config->set(vdev, offsetof(struct virtio_net_config, mac),
> > +				  dev->dev_addr, dev->addr_len);
> > +	}
> 
> Please make sure you test this with a host which doesn't set a default
> mac address, otherwise it's "untested buggy code" :-)

Good idea, I'll hack the backend to not advertise that feature and make
sure this code gets exercised a least once.  Thanks,

Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html