lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Jan 2009 10:15:06 +0000 From: Mark McLoughlin <markmc@...hat.com> To: Alex Williamson <alex.williamson@...com> Cc: Rusty Russell <rusty@...tcorp.com.au>, kvm <kvm@...r.kernel.org>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH 1/4] virtio_net: Allow setting the MAC address of the NIC On Tue, 2009-01-13 at 14:23 -0700, Alex Williamson wrote: Commit log explaining why we need this. > Signed-off-by: Alex Williamson <alex.williamson@...com> Acked-by: Mark McLoughlin <markmc@...hat.com> > + } else { > random_ether_addr(dev->dev_addr); > + vdev->config->set(vdev, offsetof(struct virtio_net_config, mac), > + dev->dev_addr, dev->addr_len); > + } Please make sure you test this with a host which doesn't set a default mac address, otherwise it's "untested buggy code" :-) Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists