netdev - Re: [PATCH 10/34]bnx2x: Compilation issue on IA64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Jan 2009 17:07:04 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Eilon Greenstein <eilong@...adcom.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 10/34]bnx2x: Compilation issue on IA64

On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> ---
>  drivers/net/bnx2x_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
> index 4993707..ba56d1c 100644
> --- a/drivers/net/bnx2x_main.c
> +++ b/drivers/net/bnx2x_main.c
> @@ -1199,7 +1199,7 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
>  
>  #ifdef BNX2X_STOP_ON_ERROR
>  	fp->tpa_queue_used |= (1 << queue);
> -#ifdef __powerpc64__
> +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
>  	DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
>  #else
>  	DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",

Or you could cast the value to unsigned long long and remove this
fragile #ifdef.

Maybe <linux/types.h> should define format strings like C99's PRIx64..

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html