netdev - Re: [PATCH 05/34]bnx2x: Setting the GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1231961380.25524.0.camel@lb-tlvb-eliezer>
Date:	Wed, 14 Jan 2009 21:29:40 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
cc:	"David Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO

On Wed, 2009-01-14 at 10:00 -0800, Ben Hutchings wrote:
> On Wed, 2009-01-14 at 19:42 +0200, Eilon Greenstein wrote:
> > On Wed, 2009-01-14 at 08:57 -0800, Ben Hutchings wrote:
> > > On Wed, 2009-01-14 at 18:42 +0200, Eilon Greenstein wrote:
> > > > When TPA (HW GRO) is used, the GSO_TYPE should be set
> > > [...]
> > > 
> > > No it shouldn't.  That is for the output path only.
> > > 
> > 
> > Right - but it was an issue with forwarding
> 
> You can't use LRO together with forwarding/bridging unless you replicate
> what Herbert Xu has done to allow reconstruction of the original frames.
> Setting gso_type is a hack which you may or may not get away with,
> depending on the output device's capabilities.
> 
This is far from bullet proof solution, but IMHO it is better set then
not  this way, you stand a chance (depending on the output device
capabilities)

Eilon


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html