netdev - Re: [PATCH 05/34]bnx2x: Setting the GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jan 2009 07:18:26 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Eilon Greenstein <eilong@...adcom.com>
Cc:	bhutchings@...arflare.com, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO

Eilon Greenstein <eilong@...adcom.com> wrote:
>> 
> This is far from bullet proof solution, but IMHO it is better set then
> not  this way, you stand a chance (depending on the output device
> capabilities)

The question is simple, does your hardware guarantee that on
output GSO will turn the packet into exactly the same sequence
of packets that was seen on input, with no changes (apart from
what the stack would have done to them anyway, e.g., TTL update)
whatsoever?

If not then you mustn't set this and also you must disable it
if forwarding/bridging is used.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html