netdev - Re: [PATCH 02/34]bnx2x: Barriers for the compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Jan 2009 13:13:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 02/34]bnx2x: Barriers for the compiler

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Wed, 14 Jan 2009 18:42:44 +0200

> To make sure no swapping are made by the compiler, changed HAS_WORK to inline
> functions and added all the necessary barriers
> 
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

Don't you need cpu memory barriers too?  What if the cpu reorders what
you're trying to order using just a compiler barrier?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html