netdev - Re: [PATCH 05/34]bnx2x: Setting the GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090114.131206.193936587.davem@davemloft.net>
Date:	Wed, 14 Jan 2009 13:12:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	herbert@...dor.apana.org.au, eilong@...adcom.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 14 Jan 2009 20:27:22 +0000

> On Thu, 2009-01-15 at 07:18 +1100, Herbert Xu wrote:
> > Eilon Greenstein <eilong@...adcom.com> wrote:
> > >> 
> > > This is far from bullet proof solution, but IMHO it is better set then
> > > not  this way, you stand a chance (depending on the output device
> > > capabilities)
> > 
> > The question is simple, does your hardware guarantee that on
> > output GSO will turn the packet into exactly the same sequence
> > of packets that was seen on input, with no changes (apart from
> > what the stack would have done to them anyway, e.g., TTL update)
> > whatsoever?
> > 
> > If not then you mustn't set this and also you must disable it
> > if forwarding/bridging is used.
> 
> The driver just has to cooperate with dev_disable_lro() in order for the
> forwarding/bridging code to disable it.  Then skb_warn_if_lro() should
> catch the case where the user mistakenly turns it back on.  However,
> setting gso_type on input subverts this check.

Right, setting gso_type here is absolutely wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html