netdev - Re: [RFC] FEC patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090115102413.GT11228@pengutronix.de>
Date:	Thu, 15 Jan 2009 11:24:13 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Greg Ungerer <gerg@...pgear.com>
Cc:	netdev@...r.kernel.org, Sebastian Siewior <bigeasy@...utronix.de>
Subject: Re: [RFC] FEC patches

On Thu, Jan 15, 2009 at 02:06:55PM +1000, Greg Ungerer wrote:
> Hi Sacha,
>
> Sascha Hauer wrote:
>> The following patches apply to the FEC driver (drivers/net/fec.c). While
>> found on several Freescale/Motorola chips, this driver is currently only
>> used for Coldfire. These patches add support for the ARM based i.MX27
>> SoC.
>>
>> I'm almost sure I break the driver for some (all?) Coldfire guys, but I
>> do not have any Coldfire based board to test the patches on.
>
> I can test patches on most ColdFire boards.
>
>
>> The first 4 patches should be ok as is, comments?
>
> Only the one that I commented on with FEC_FLASHMAC.
> Otherwise the first 4 apply and work for ColdFire.
>
>
>> The other patches are somewhat work in progress, but they show which
>> changes I need for my hardware.
>
> Currently the change to use dma_alloc_coherent breaks ColdFire.
> I need to debug that and see why that is the case.
>
> Otherwise they look ok to me.
>
>
>> The driver could use quite some cleanup patches for coding style, turn
>> it into a platform device driver and add exit functions. I'm sure I
>
> Yes, it does badly need this. I have been meaning to extract
> the ColdFire platform specifics for some time. That would improve
> it quite a bit.
>

My plan is to put the current static initialization code into some kind
of #ifdef FEC_LEGACY and use a proper platform device driver otherwise.
This would leave the code in place for now and it could be ported over
to platform devices per platform. Is this ok for you?

Regards
  Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html