netdev - Re: [PATCH] fec: remove unused #else branches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jan 2009 11:17:03 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Greg Ungerer <gerg@...pgear.com>
Cc:	netdev@...r.kernel.org, Sebastian Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] fec: remove unused #else branches

On Thu, Jan 15, 2009 at 01:43:24PM +1000, Greg Ungerer wrote:
> Hi Sascha,
>
> Sascha Hauer wrote:
>> The #else branches throughout this driver belong to a PowerPC 8xx for
>> which this driver is not used.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
>> ---
>>  drivers/net/fec.c |   94 -----------------------------------------------------
>>  1 files changed, 0 insertions(+), 94 deletions(-)
>>
>> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
>> index 7e33c12..95785ef 100644
>> --- a/drivers/net/fec.c
>> +++ b/drivers/net/fec.c
>> @@ -72,8 +72,6 @@ static unsigned int fec_hw[] = {
>>  	(MCF_MBAR+0x30000),
>>  #elif defined(CONFIG_M532x)
>>  	(MCF_MBAR+0xfc030000),
>> -#else
>> -	&(((immap_t *)IMAP_ADDR)->im_cpm.cp_fec),
>>  #endif
>>  };
>>  @@ -95,8 +93,6 @@ static unsigned char	fec_mac_default[] = {
>>  #define	FEC_FLASHMAC	(0xffe04000 + 4)
>>  #elif defined(CONFIG_MOD5272)
>>  #define FEC_FLASHMAC 	0xffc0406b
>> -#else
>> -#define	FEC_FLASHMAC	0
>>  #endif
>
> The breaks building for a few of the ColdFire targets. They
> expect FEC_FLASHMAC to be defined to something.
>
> Those cases could be fixed with "#ifdef"s around them,
> or by leaving this "#else" in place (simpler).

Ok, I'll leave this #else in.

Regards,
  Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html