netdev - Re: [PATCH - REPOST] asix.c - Add support for AX88772A devices -

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090115.082253.154478845.davem@davemloft.net>
Date:	Thu, 15 Jan 2009 08:22:53 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dhollis@...ehollis.com
Cc:	bhutchings@...arflare.com, jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH - REPOST] asix.c - Add support for AX88772A devices -

From: David Hollis <dhollis@...ehollis.com>
Date: Thu, 15 Jan 2009 08:09:34 -0500

> On Wed, 2009-01-14 at 16:53 +0000, Ben Hutchings wrote:
> 
> > > @@ -1451,6 +1588,10 @@ static const struct usb_device_id        produc
> > >         // Cables-to-Go USB Ethernet Adapter
> > >         USB_DEVICE(0x0b95, 0x772a),
> > >         .driver_info = (unsigned long) &ax88772_info,
> > > +}, {
> > > +       // ASIX AX88772A
> > > +       USB_DEVICE(0x0b95, 0x772a),
> > > +       .driver_info = (unsigned long) &ax88772a_info,
> > 
> > This is matching the same id as the entry above, so how will it ever be
> > used?  Do the bind operations distinguish them somehow?
> > 
> 
> Ugh!  I didn't notice that either.  Unfortunately, I don't have this new
> device to be able to test with so I have to rely on the vendors
> contribution.  I would presume that the Cables-to-Go device needs to be
> using ax88772a_info and in the current state, it isn't going to.  I'll
> check with the contributor for an assist on that.

Grrr, I just noticed this and I'm ripping this patch out of
my tree.

Sigh.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html